Initial version of nextcloud-client
ClosedPublic

Authored by kyrios123 on Aug 25 2017, 7:26 PM.

Details

Summary

Initial commit of Nextcloud

Fixes T679.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Install & run application : Ok

Diff Detail

Repository
R3740 nextcloud-client
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kyrios123 created this revision.Aug 25 2017, 7:26 PM
kyrios123 edited the summary of this revision. (Show Details)Aug 25 2017, 7:27 PM
kyrios123 added a task: T679: nextcloud.
kyrios123 added inline comments.
package.yml
10

Although I set libsplit to no, it still creates a -devel package... why?

24

I did put a couple of deps for KDE for @sunnyflunk but I am not sure if it's a good idea for non-kde users ?

Justin added a subscriber: Justin.Aug 31 2017, 2:42 AM

Do the kde deps have any purpose? Do they integrate it better with Plasma?
Just tested your build and the -devel split isn't causing any issues, hooked it up to a new nextcloud docker image on my server OK and synced some files.

In D876#13177, @Justin wrote:

Do the kde deps have any purpose? Do they integrate it better with Plasma?
Just tested your build and the -devel split isn't causing any issues, hooked it up to a new nextcloud docker image on my server OK and synced some files.

I don't know to be honest, I haven't had time to give a try on KDE on Solus. These are the optional dependencies I added. I think it's mainly to integrate nextcloud with dolphin. If you have Plasma, you could give a try and eventually compare with owncloud which hasn't these dependencies atm. Or maybe @sunnyflunk could advise ?
Otherwise I can remove them, nothing prevent us to add them back later when Plasma is ready for an official launch ?

  • extra-cmake-modules
  • kcoreaddons-devel
  • kio-devel
JoshStrobl requested changes to this revision.Sep 13 2017, 10:57 AM
JoshStrobl added a subscriber: JoshStrobl.

I'd recommend splitting the KDE bits into its own subpackage, like kde-integration, so that way our current users aren't getting a bunch of KDE deps for a DE or file manager they might not use.

This revision now requires changes to proceed.Sep 13 2017, 10:57 AM
kyrios123 updated this revision to Diff 2268.Sep 13 2017, 2:22 PM

move dolphin integration stuffs in -kde-dolphin sub-package

ikey added a subscriber: ikey.Sep 13 2017, 2:45 PM

So if the idea is that this supports multiple file managers, why is only dolphin being split and not nautilus?

Actually, just like owncloud, it supports nautilus, caja and nemo (but here I removed nemo as it's not in the repo). It also supports dolphin, but extra build dependencies are required.
I made this package few time after updating krita for which @sunnyflunk explicitly requested to add extra dependencies for plasma now it's there.
So I thought that it could be nice to offer the same integration as on the other DE as it is available (but it's true that unlike Krita, this is not a "K" application).

For me it's fine to split all the files managers or to remove the kde one. It's now always clear how such things are decided. For the python packages it is also confusing sometimes I upgrade a python 2 package and I'm requested to also add python 3 and some other times I do it and I am requested to remove it. Not a big deal, it's very quick to change so I guess nobody really mind but it could be a point to clarify later.

Actually, just like owncloud, it supports nautilus, caja and nemo (but here I removed nemo as it's not in the repo). It also supports dolphin, but extra build dependencies are required.
I made this package few time after updating krita for which @sunnyflunk explicitly requested to add extra dependencies for plasma now it's there.
So I thought that it could be nice to offer the same integration as on the other DE as it is available (but it's true that unlike Krita, this is not a "K" application).

It was less for plasma (it runs the same on Budgie as it does Plasma), but more to make it fully functional (there is less reason to keep it lean now that all the KDE frameworks are available for plasma, which wasn't true when it was added). Without KIO, some stuff would have been broken, simply no-one has run into it yet, and most of KIO's deps are already installed with krita.

KIO is a relatively fat dep (at least in terms of number of packages it pulls in), which is the difference between the dolphin support and other FM's (which don't add deps, python \o/). If it existed without depending on kio, there would be no issue. Perhaps have some consistent naming scheme as well. It's less about kde support, than dolphin support as I imagine dolphin will become a popular choice for budgie 11 (even though not the default).

From above, libsplit doesn't prevent a -devel being created, It just makes the %libdir%/*.so (maybe .a) not be split to -devel. There's still headers provided to make a -devel package

It was less for plasma (it runs the same on Budgie as it does Plasma), but more to make it fully functional (there is less reason to keep it lean now that all the KDE frameworks are available for plasma, which wasn't true when it was added). Without KIO, some stuff would have been broken, simply no-one has run into it yet, and most of KIO's deps are already installed with krita.

KIO is a relatively fat dep (at least in terms of number of packages it pulls in), which is the difference between the dolphin support and other FM's (which don't add deps, python \o/). If it existed without depending on kio, there would be no issue. Perhaps have some consistent naming scheme as well. It's less about kde support, than dolphin support as I imagine dolphin will become a popular choice for budgie 11 (even though not the default).

From above, libsplit doesn't prevent a -devel being created, It just makes the %libdir%/*.so (maybe .a) not be split to -devel. There's still headers provided to make a -devel package

Thanks for the feedback, it really help getting a better understanding !

For this package, what shall we do ?

@kyrios123 For now, please disable the KDE / Dolphin support until @sunnyflunk and I agree on a sub-package name for it. Thanks!

@JoshStrobl do you mind if I just comment the dolphin related stuffs so it could eventually be easily enabled back later or shall I completely remove it from the the package.yml file ?

Yea go ahead and comment it out. Not our usual practice but I don't anticipate it being like that for long anyways.

kyrios123 updated this revision to Diff 2507.Sep 21 2017, 11:54 AM

disable kde/dolphin integration

JoshStrobl accepted this revision.Sep 21 2017, 3:01 PM
This revision is now accepted and ready to land.Sep 21 2017, 3:01 PM
This revision was automatically updated to reflect the committed changes.