Update cups to 2.2.6 + convert to ypkg
ClosedPublic

Authored by kyrios123 on Aug 12 2017, 9:21 PM.

Details

Summary

Release notes available here 2.2.5 - 2.2.6

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Installation ok

Diff Detail

Repository
R575 cups
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kyrios123 created this revision.Aug 12 2017, 9:21 PM
EP01 added a subscriber: EP01.Aug 13 2017, 10:48 AM
EP01 added inline comments.
package.yml
4

I'm not experienced enough to comment on the rest of the package, but the release number should be 16.

ikey requested changes to this revision.Aug 13 2017, 10:57 AM
ikey added a subscriber: ikey.
ikey added inline comments.
files/cups-multilib.patch
10 ↗(On Diff #1781)

This stuff seems cranky and wrong, we didn't need a multilib patch before so why do we need one now.. ?

files/cups-no-export-ssllibs.patch
9 ↗(On Diff #1781)

I need clarification on why this patch is present - Fedora having it isn't a good enough reason

package.yml
45

Can I see the build failure? We might have a dependency issue in the 32-bit build of gnutls

58

Please be sure to use 5-octal notation, i.e. 00644 not 644. This is a very little documented part of install, but it clears parent permission problems. For example, if somehow an upper directory becomes setgid, then install will continue that setgid mask across -D subdirectory creation, which can be incredibly dangerous! :)

pspec_x86_64.xml
24

Guess Ikey needs to make this stateless at some point :P

This revision now requires changes to proceed.Aug 13 2017, 10:57 AM
kyrios123 added inline comments.Aug 13 2017, 11:33 AM
files/cups-no-export-ssllibs.patch
9 ↗(On Diff #1781)

ok I only leave the patches that I believe are really important.

package.yml
45

This is what I get when gnutls is enabled for the 32bit build:
https://hastebin.com/suyilidino

libgnutls-32bit should depend on libp11-kit-32bit but doesn't (the non 32bit package has the correct dependency).

If you can't justify why you are adding a patch, you shouldn't add it IMO

kyrios123 updated this revision to Diff 1789.Aug 13 2017, 11:51 AM
kyrios123 removed a subscriber: sunnyflunk.

DRAFT - Update 1

  • Removed some patches
    • Don't gzip man pages in the Makefile
    • Prevent multilib conflict in cups-config script
    • Don't export SSLLIBS to cups-config.
  • add tmpfiles
  • fix release number
  • use octal permissions in install -m
  • Remove Fedora hacks to log into the journal instead of syslog: first make it work, enhance it later.
  • Add some more configure options (user, group, system groups, without rcdir)
IMPORTANT: ANYONE WILLING TO HELP FOR THE TESTS IS WELCOME !!!!
kyrios123 updated this revision to Diff 1794.Aug 13 2017, 1:30 PM
kyrios123 edited the summary of this revision. (Show Details)
  • 32bit is now built with gnutls support
  • remove a couple of builddeps
kyrios123 updated this revision to Diff 1812.EditedAug 14 2017, 5:37 PM
kyrios123 edited the summary of this revision. (Show Details)
kyrios123 edited the test plan for this revision. (Show Details)

This could be considered as the release candidate version of the package. It's ready for testing and if nobody ask for changes, it can be committed 😜

ikey added a comment.Aug 14 2017, 5:39 PM

Won't be going in tonight I'm afraid, just can't risk it. About to do the release

kyrios123 retitled this revision from Update cups to 2.2.4 + convert to package.yml DRAFT to Update cups to 2.2.4 + convert to package.yml.Aug 14 2017, 5:42 PM
In D809#11851, @ikey wrote:

Won't be going in tonight I'm afraid, just can't risk it. About to do the release

You're a wise man and I wouldn't want to feel responsible for breaking printing for everyone !

kyrios123 added inline comments.Aug 14 2017, 7:52 PM
package.yml
56

make check is currently commented because 1 test fails:

./testhttp
httpGetDateString()/httpGetDateTime(): PASS
httpDecode64_2()/httpEncode64_2(): PASS
httpGetHostname(): PASS (solus-budgie)
httpAddrGetList(solus-budgie): FAIL
httpSeparateURI(): PASS (41 URIs tested)
httpAssembleURI(): PASS (16 URIs tested)
httpAssembleUUID: PASS (urn:uuid:54095e9c-ee9b-3a04-7566-1d3a6342da2c)

I have a printer but am not currently using unstable @kyrios123 I could maybe setup a virtual machine if you would like

I have a printer but am not currently using unstable @kyrios123 I could maybe setup a virtual machine if you would like

Any help for testing is welcome but the package is not yet on unstable.
I uploaded the .eopkg files here.

PS: if you set a virtual machine on stable, it should also work if the system is up-to-date.

kyrios123 updated this revision to Diff 1906.Aug 23 2017, 2:23 PM

Add libgnutls-devel as rundep for cups-devel

kyrios123 updated this revision to Diff 1926.Aug 24 2017, 4:58 PM

fix typo in tmpfiles

kyrios123 updated this revision to Diff 2736.Oct 3 2017, 5:00 PM

remove the "no-gcrypt" patch

ikey requested changes to this revision.Oct 4 2017, 11:29 PM

The Gentoo patch for the systemd units breaks the existing paths in our cups package, thus breaks upgrades

This revision now requires changes to proceed.Oct 4 2017, 11:29 PM
In D809#17968, @ikey wrote:

The Gentoo patch for the systemd units breaks the existing paths in our cups package, thus breaks upgrades

I'd like to discuss this on IRC when you're available

kyrios123 updated this revision to Diff 2794.Oct 5 2017, 2:26 PM

pre-enable boot service, socket & path

kyrios123 updated this revision to Diff 2795.Oct 5 2017, 2:58 PM

fix indentation

kyrios123 updated this revision to Diff 2796.Oct 5 2017, 3:37 PM
kyrios123 edited the summary of this revision. (Show Details)
kyrios123 edited the test plan for this revision. (Show Details)
  • rm /run and /var as this is handled by the tmpfiles
  • lpadmin is a group, not a user
kyrios123 updated this revision to Diff 2946.Oct 13 2017, 9:41 PM
kyrios123 retitled this revision from Update cups to 2.2.4 + convert to package.yml to Update cups to 2.2.5 + convert to ypkg.
kyrios123 edited the summary of this revision. (Show Details)

bump to 2.2.5

  • restore original service, socket & path names
  • add libgcrypt-32bit-devel and xz-32bit-devel as dependencies because cups doesn't build anymore without them
kyrios123 updated this revision to Diff 2948.Oct 13 2017, 10:10 PM
  • also add LGPL-2.0 as license
  • add 32bit rundep
kyrios123 updated this revision to Diff 3164.Nov 1 2017, 7:03 PM
kyrios123 retitled this revision from Update cups to 2.2.5 + convert to ypkg to Update cups to 2.2.6 + convert to ypkg.
kyrios123 edited the summary of this revision. (Show Details)
kyrios123 edited the test plan for this revision. (Show Details)

bump to 2.2.6

ikey accepted this revision.Wed, Nov 29, 10:31 PM
This revision is now accepted and ready to land.Wed, Nov 29, 10:31 PM
This revision was automatically updated to reflect the committed changes.