Initial commit of plex-media-player
ClosedPublic

Authored by der_eismann on Jun 28 2017, 8:23 PM.

Details

Summary

Initial commit of plex-media-player, fixes T1803.

It also wants breakpad, but it's not necessary, I guess it is just for crash reporting.

Test Plan

Played several movies and tracks from my local Plex server, tested different bandwidths.

Diff Detail

Repository
R4050 plex-media-player
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
der_eismann created this revision.Jun 28 2017, 8:23 PM
der_eismann edited the summary of this revision. (Show Details)Jun 28 2017, 8:26 PM
der_eismann updated this revision to Diff 1107.Jun 28 2017, 9:18 PM

Sorting the order of builddeps.

der_eismann updated this revision to Diff 1797.Aug 13 2017, 2:28 PM

Update to 1.3.5

Justin edited reviewers, added: Justin; removed: Triage Team.Aug 25 2017, 12:22 AM
Justin edited edge metadata.

Awaiting Ikey's approval as package requires networking during build.

Justin edited reviewers, added: ikey; removed: Justin.Sep 12 2017, 12:02 AM
der_eismann added a comment.EditedSep 23 2017, 4:06 PM

Has @ikey decided yet? It's still building fine, but unfortunately the program doesn't start anymore after building, updating to the latest 1.3.6 doesn't help. Maybe the dependencies have changed.
But no hurry, this commit is only 3 months old.

2017-09-23 17:53:07 [ ERROR ] InputLIRC.cpp @ 82 - LIRC Socket Error :  QLocalSocket::ServerNotFoundError 
2017-09-23 17:53:07 [ ERROR ] ComponentManager.cpp @ 49 - Failed to init component: display 
2017-09-23 17:53:08 [ WARN  ] SettingsSection.cpp @ 82 - Looking for value: "clientID" in section: "webclient" but it can't be found 
2017-09-23 17:53:08 [ WARN  ] Log.cpp @ 35 - "QQmlApplicationEngine failed to load component" 
2017-09-23 17:53:08 [ WARN  ] Log.cpp @ 35 - "qrc:/ui/webview.qml:6 module \"QtQuick.Controls\" is not installed\n" 
2017-09-23 17:53:08 [ FATAL ] main.cpp @ 264 - Unhandled FatalException: Failed to parse application engine script.
Justin added a subscriber: Justin.Sep 27 2017, 12:04 AM

Has @ikey decided yet? It's still building fine, but unfortunately the program doesn't start anymore after building, updating to the latest 1.3.6 doesn't help. Maybe the dependencies have changed.
But no hurry, this commit is only 3 months old.

2017-09-23 17:53:07 [ ERROR ] InputLIRC.cpp @ 82 - LIRC Socket Error :  QLocalSocket::ServerNotFoundError 
2017-09-23 17:53:07 [ ERROR ] ComponentManager.cpp @ 49 - Failed to init component: display 
2017-09-23 17:53:08 [ WARN  ] SettingsSection.cpp @ 82 - Looking for value: "clientID" in section: "webclient" but it can't be found 
2017-09-23 17:53:08 [ WARN  ] Log.cpp @ 35 - "QQmlApplicationEngine failed to load component" 
2017-09-23 17:53:08 [ WARN  ] Log.cpp @ 35 - "qrc:/ui/webview.qml:6 module \"QtQuick.Controls\" is not installed\n" 
2017-09-23 17:53:08 [ FATAL ] main.cpp @ 264 - Unhandled FatalException: Failed to parse application engine script.

Looks like it needs pkgconfig(Qt5QuickControls2)

der_eismann updated this revision to Diff 2919.Oct 10 2017, 9:33 PM

Fixed the Fatal error

Okay, I am ready for the approval @Justin

A couple of things I noticed.

Additionally, for @ikey I did some digging and if we want to build this without networking we'll have to pre package plex-web-client and put it on the server.
https://forums.plex.tv/discussion/284334/download-link-for-web-client-to-build-plex-media-player-package-on-freebsd

package.yml
31

We already have CMAKE_BUILD_TYPE and CMAKE_INSTALL_PREFIX as part of our %cmake macro Are you sure you need -DQTROOT=/usr/share/qt5/ as well?

36

This is a nitpick but could these be -Dm644 instead.

37

The icon should be installed to $installdir/usr/share/pixmaps/ not to an icon theme.

joebonrichie requested changes to this revision.Oct 11 2017, 11:25 AM
This revision now requires changes to proceed.Oct 11 2017, 11:25 AM
der_eismann updated this revision to Diff 2930.Oct 11 2017, 5:43 PM
der_eismann edited edge metadata.

Include Joe's suggestions

der_eismann marked 2 inline comments as done.Oct 11 2017, 5:49 PM

Hey Joe, thanks for your quick reply and constructive criticism! I applied your suggestions, looks fine.
However I'm not sure about this whole Conan-thing... I have never worked with it before and even if we pre-package it we would have to use networking for the pre-package, right?

package.yml
31

You were right, two of them are unnecessary. However the -DQTROOT seems necessary, building without it fails and it's also mentioned on the GitHub page:

If you use your distro's Qt, use -DQTROOT=/usr or similar.

der_eismann updated this revision to Diff 3213.Nov 5 2017, 2:24 PM

Update to 1.3.11

Justin edited subscribers, added: ikey; removed: Justin.Nov 6 2017, 11:27 PM

As discussed due to networking Ikey will need to be the one to approve this one.

zevdg added a subscriber: zevdg.Nov 14 2017, 8:42 PM
zevdg added inline comments.
files/plex-media-player.desktop
10

I had to add StartupWMClass=plexmediaplayer here to prevent duplicate icons in the gnome shell launcher when plexmediaplayer was pinned.

Another month gone... @ikey, is networking okay?

der_eismann updated this revision to Diff 5368.Feb 9 2018, 10:28 PM

Update to 2.4.1

der_eismann marked an inline comment as done.Feb 9 2018, 10:30 PM

Didn't have the pinning problem, but won't hurt. Still have to wait for @ikey though.

Delete folder /usr/resources

ikey accepted this revision.Feb 12 2018, 12:43 PM

LGTM

This revision was automatically updated to reflect the committed changes.