mysql-connector-cpp
Needs RevisionPublic

Authored by frbuceta on Nov 16 2017, 10:20 PM.

Details

Summary

Get connect mariadb with MySQL workbench

Test Plan

Tested in a c ++ test

https://dev.mysql.com/doc/connector-cpp/en/connector-cpp-examples-complete-example-1.html

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
frbuceta created this revision.Nov 16 2017, 10:20 PM
frbuceta edited the summary of this revision. (Show Details)Nov 16 2017, 10:29 PM
JoshStrobl requested changes to this revision.Nov 18 2017, 7:03 PM
JoshStrobl added a subscriber: JoshStrobl.
  1. You need to actually rebuild this.
  2. You don't need to Markdown the differential link, Phab will automatically do that.
  3. You didn't add a test plan, so how did you test this?
This revision now requires changes to proceed.Nov 18 2017, 7:03 PM
frbuceta updated this revision to Diff 3515.Nov 19 2017, 7:45 PM
frbuceta edited the summary of this revision. (Show Details)
frbuceta edited the test plan for this revision. (Show Details)

Update patch files

JoshStrobl requested changes to this revision.Nov 20 2017, 7:54 PM

compilation satisfactory

This is not a valid test plan. Explain in the test plan how you tested this library.

This revision now requires changes to proceed.Nov 20 2017, 7:54 PM
frbuceta updated this revision to Diff 3564.Nov 21 2017, 7:32 PM

Fix library

frbuceta edited the test plan for this revision. (Show Details)Nov 21 2017, 7:33 PM

Tested in a c ++ test

Do you have any example code for the test plan?

JoshStrobl requested changes to this revision.Dec 4 2017, 9:43 PM
This revision now requires changes to proceed.Dec 4 2017, 9:43 PM

@frbuceta here is some example code to try so you can finish the diff

frbuceta added a comment.EditedFri, Dec 22, 3:41 PM

@frbuceta here is some example code to try so you can finish the diff

Tested in a c ++ test

Do you have any example code for the test plan?

I have not tried it but I think it works

frbuceta requested review of this revision.Fri, Dec 22, 3:42 PM
frbuceta edited the test plan for this revision. (Show Details)
JoshStrobl requested changes to this revision.Thu, Dec 28, 6:02 PM

Please ensure you are using our generating a package.yml script, because I'm seeing a lot of inconsistent spacing here and you're using 8 spaces instead of 4.

This revision now requires changes to proceed.Thu, Dec 28, 6:02 PM