Update python-qt4 to 4.12.1
ClosedPublic

Authored by kyrios123 on Sep 16 2017, 9:22 PM.

Details

Summary

This is a minor bug-fix release.

  • SIP v4.19.1 is now required.
  • Bug fixes.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Diff Detail

Repository
R2678 python-qt4
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kyrios123 created this revision.Sep 16 2017, 9:22 PM

@kyrios123 this needs to be tested for everything that builds against it. I have had problems with previous updates and been forced to hold it back before.

@kyrios123 this needs to be tested for everything that builds against it. I have had problems with previous updates and been forced to hold it back before.

Ok I will do. Would you mind copy/pasting the list of the reverse dependencies of python-qt4 and python-sip because I don't have a copy of the whole repository.

@kyrios123 just use eopkg info <pkgname>. It's how we check for rebuilds, etc.

@kyrios123 this needs to be tested for everything that builds against it. I have had problems with previous updates and been forced to hold it back before.

@DataDrake I did he following checks is it enough ?

  • python-sip..............................build/install/run binary
    • python-qt4.....................build/install/run binaries
      • puddletag...............build/install/start application
      • python-qscintilla...build/install (used by qgis)
      • qgis..........................build/install/start application
      • picard......................build/install/start application
      • bitmessage.............build/install/start application
      • electrum.................build/install/start application
    • python-qt5.....................build/install/run binaries
      • calibre.....................build/install/start application
kyrios123 updated this revision to Diff 3410.Thu, Nov 16, 2:13 PM

Update flags

kyrios123 edited the test plan for this revision. (Show Details)Thu, Nov 16, 2:42 PM
kyrios123 edited the test plan for this revision. (Show Details)Thu, Nov 16, 2:47 PM
JoshStrobl accepted this revision.Sat, Nov 18, 7:25 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
21–24

Spacing looks like 8 rather than 4.

This revision is now accepted and ready to land.Sat, Nov 18, 7:25 PM
kyrios123 updated this revision to Diff 3459.Sat, Nov 18, 7:42 PM

fix space alignment

JoshStrobl requested changes to this revision.Sat, Nov 18, 8:50 PM
JoshStrobl added inline comments.
package.yml
21–24

Wat no I meant 4 space indentation. You had 8 on top of the 4 indented.

This revision now requires changes to proceed.Sat, Nov 18, 8:50 PM
kyrios123 updated this revision to Diff 3482.Sun, Nov 19, 10:20 AM

fix spaces alignment in package.yml

JoshStrobl accepted this revision.Sun, Nov 19, 11:20 AM
This revision is now accepted and ready to land.Sun, Nov 19, 11:20 AM
This revision was automatically updated to reflect the committed changes.